forked from apache/incubator-pegasus
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Distinguish log file names and limit log file count #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
force-pushed
the
dis_log_dirs
branch
2 times, most recently
from
May 21, 2024 01:53
0f7caaf
to
4b312be
Compare
acelyc111
changed the title
Dis log dirs
feat: Distinguish log file names and limit log file count
May 21, 2024
acelyc111
force-pushed
the
dis_log_dirs
branch
2 times, most recently
from
May 21, 2024 02:00
ebdf3f5
to
e376e1a
Compare
This patch adds a new flag `--separate_servers` to indicate whether to build `pegasus_collector`,`pegasus_meta_server` and `pegasus_replica_server` binaries separately, otherwise a combined `pegasus_server` binary will be built. The corresponding option in CMake is `SEPARATE_SERVERS`.
There are 2 options stats_dump_period_sec and stats_persist_period_sec in RocksDB to adjust the period to dump/persist stat, each RocksDB instance creates 2 dependent threads for this aim. A replica server is possible to serve thousands of replicas, it means thousands of RocksDB instances are possible to be running in one process, then thousands of threads will be created will may consume much resouce. This patch introduces 2 options, then it's possible to disable the threads by setting them to 0.
Fix build failures like: 1. ``` /bin/ld: /.../thirdparty/output/lib/libcurl.a(libcurl_la-content_encoding.o): in function `brotli_close_writer': content_encoding.c:(.text+0x2c): undefined reference to `BrotliDecoderDestroyInstance' ``` 2. ``` /bin/ld: /.../thirdparty/output/lib/libcurl.a(libcurl_la-easy.o): relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `malloc' which may bind externally can not be used when making a shared object; recompile with -fPIC /bin/ld: /.../thirdparty/output/lib/libcurl.a(libcurl_la-easy.o)(.text+0x30): unresolvable R_AARCH64_ADR_PREL_PG_HI21 relocation against symbol `malloc' ``` 3. ``` /bin/ld: idn.c:(.text+0x34): undefined reference to `idn2_lookup_ul' ```
…pache#2016) fix(aarch64): Set the correct LD_LIBRARY_PATH for aarch64 platforms
Bumps google.golang.org/protobuf from 1.29.1 to 1.33.0.
…ion (apache#2019) Use the current working directory rather than the fixed '/home/work/' directory.
Add a new configuration 'log_dir' to indicate the directory to place the logs especially. 'data_dir' will be used if it's empty. ```diff [core] +log_dir = ```
Mainly including: - Using fmt::format/print instead of sprintf/printf, which is more convenient and faster - Add some configuration validators - Encapsulate print_header(), print_long_header() and print_body() for screen_logger and simple_logger - Add more comments - Naming improvment
…size and total count (apache#2024) - A new symlink is added to point to the latest log file, the symlink is in the same directory as the log files. **Behavior change:** - Log file is rolled by `max_log_file_bytes` configuration (64MB by default) instead of the fixed line count, i.e. 200000. - Log files are named as `log.<yyyyMMdd_hhmmss_SSS>`, e.g. log.20240524_1806_235 instead of `log.<index>.txt`, e.g. log.123.txt ```diff [tools.simple_logger] +max_log_file_bytes = ```
Move lookup_hostname() from utils/utils.h to rpc_host_port, and remove the use less addr2host() in src/base/pegasus_utils.h There is no functionality changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.